Skip to content

fix: dockerfile deps and cmd #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2019
Merged

fix: dockerfile deps and cmd #37

merged 1 commit into from
Dec 17, 2019

Conversation

satazor
Copy link
Collaborator

@satazor satazor commented Dec 17, 2019

  • The intl package needs some OS deps
  • The CMD now correctly starts the server on $PORT

@satazor satazor changed the title fix: fix dockerfile deps and cmd fix: dockerfile deps and cmd Dec 17, 2019
@satazor satazor requested a review from ivolimasilva December 17, 2019 02:50
@satazor
fix: dockerfile deps and cmd
516cadf 
- The intl package needs some OS deps
- The CMD now correctly starts the server on $PORT
ivolimasilva
ivolimasilva approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@ivolimasilva ivolimasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already test in a project and it's working correctly.

@satazor satazor merged commit 547d662 into master Dec 17, 2019
@satazor satazor deleted the fix/dockerfile-cmd branch December 17, 2019 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivolimasilva ivolimasilva ivolimasilva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@satazor @ivolimasilva