Skip to content

tests: remove broken temp_queue test #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

jcristau
Copy link
Contributor

temp_queue downloads were reverted in 32.0.2, and while the test was partially kept, it didn't do anything, which was made obvious by python/cpython#100690, when the call to called_once_with started raising.

E AttributeError: 'called_once_with' is not a valid assertion. Use a spec for the mock if 'called_once_with' is meant to be an attribute.. Did you mean: 'assert_called_once_with'?

@jcristau jcristau requested a review from a team November 26, 2024 10:29
temp_queue downloads were reverted in 32.0.2, and while the test was
partially kept, it didn't do anything, which was made obvious by
python/cpython#100690, when the call to
`called_once_with` started raising.
@jcristau jcristau merged commit 01fcac3 into mozilla-releng:main Nov 26, 2024
10 checks passed
@jcristau jcristau deleted the temp_queue_test branch November 26, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants