Replace '-lgcc' option in ndk 23. Fixes #75. #83
Conversation
minyung
changed the title
There was a problem hiding this comment.
@minyung thanks for the patch!
I would prefer to not use the linker wrapper to do this and to handle the arguments in the plugin code, but I see that these arguments come from deep within Rust and its standard library. This is a sad situation. I will note that you can use Nightly Rust within rust-android-gradle, which shouldn't have this problem as of June 2021 or so.
I'm going to try to write a test for building against NDK 23 as part of landing this; we'll see how that goes.
|
I did a little work on the test infrastructure and got a test looking healthy that verifies we can target NDK 21, 22, and 23. (The versions supported in Github Actions right now.) I merged a slightly modified version of your patch. If CI looks green tomorrow (it's bed time here), I'll release a new version and then close this PR. Thanks again! |
The tests are green and 0.9.2 is live with this change. Let me know if it doesn't work for you, @minyung! |
|
@ncalexan |
…lla#89. This applies the fix of mozilla#83 to linker argument @files. Linker argument files are used on (at least) Windows.
…lla#89. This applies the fix of mozilla#83 to linker argument @files. Linker argument files are used on (at least) Windows.
…lla#89. This applies the fix of mozilla#83 to linker argument @files. Linker argument files are used on (at least) Windows.
Hi. I am a user of this plugin and I am always grateful using it. 👍👍
When I ran the new rust library file with NDK 23, the same issue as #75 occurred.
There were no issues with rust projects that were already built with an older ndk version.
(Just change the name of the rust library you want to build, and you'll see the issue.)
In ndk 23, I confirmed that the gcc library doesn't exist.
After changing the code, the build proceeded normally.
I would really appreciate it if you could check this issue please.
Once again, Thank you :)
reference