Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I'm interested in adding support for ES6 generators, but I thought I'd first resolve #2 and start by adding a test suite, so that there something to test against when adding ES6 support.
The suite includes tests for the behavior of
spawn
and it deliberately doesn't include tests for the promises part of Task.js. I agree that eventually it'll be a better idea to use another promises library. That is also why test promises are created with RSVP.It still needs tests for pausing and resuming tasks, the other methods available in Task and possibly the Scheduler.
I decided to overwrite Mocha's
it
function to simplify catching assertion errors that would otherwise be caught by Task.js. That way tests look like this: