Skip to content

Commit eca7998

Browse files
s-rigaudSamuel Rigaud
and
Samuel Rigaud
authored
AnimationClipCreator: default to empty string for clip name (#30666)
Co-authored-by: Samuel Rigaud <[email protected]>
1 parent 222a903 commit eca7998

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

examples/jsm/animation/AnimationClipCreator.js

+7-7
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class AnimationClipCreator {
3030

3131
const track = new NumberKeyframeTrack( trackName, times, values );
3232

33-
return new AnimationClip( null, period, [ track ] );
33+
return new AnimationClip( '', period, [ track ] );
3434

3535
}
3636

@@ -50,7 +50,7 @@ class AnimationClipCreator {
5050

5151
const track = new NumberKeyframeTrack( trackName, times, values );
5252

53-
return new AnimationClip( null, period, [ track ] );
53+
return new AnimationClip( '', period, [ track ] );
5454

5555
}
5656

@@ -59,7 +59,7 @@ class AnimationClipCreator {
5959
* in the given period.
6060
*
6161
* @param {number} duration - The duration of the animation.
62-
* @param {number} shakeScale - The scale of the shake.
62+
* @param {Vector3} shakeScale - The scale of the shake.
6363
* @return {AnimationClip} The created animation clip.
6464
*/
6565
static CreateShakeAnimation( duration, shakeScale ) {
@@ -80,7 +80,7 @@ class AnimationClipCreator {
8080

8181
const track = new VectorKeyframeTrack( trackName, times, values );
8282

83-
return new AnimationClip( null, duration, [ track ] );
83+
return new AnimationClip( '', duration, [ track ] );
8484

8585
}
8686

@@ -110,7 +110,7 @@ class AnimationClipCreator {
110110

111111
const track = new VectorKeyframeTrack( trackName, times, values );
112112

113-
return new AnimationClip( null, duration, [ track ] );
113+
return new AnimationClip( '', duration, [ track ] );
114114

115115
}
116116

@@ -128,7 +128,7 @@ class AnimationClipCreator {
128128

129129
const track = new BooleanKeyframeTrack( trackName, times, values );
130130

131-
return new AnimationClip( null, duration, [ track ] );
131+
return new AnimationClip( '', duration, [ track ] );
132132

133133
}
134134

@@ -158,7 +158,7 @@ class AnimationClipCreator {
158158

159159
const track = new ColorKeyframeTrack( trackName, times, values );
160160

161-
return new AnimationClip( null, duration, [ track ] );
161+
return new AnimationClip( '', duration, [ track ] );
162162

163163
}
164164

0 commit comments

Comments
 (0)