Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnimationClipCreator: default to empty string for clip name #30666

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

s-rigaud
Copy link
Contributor

@s-rigaud s-rigaud commented Mar 6, 2025

Description

There was a type inconsistency, null was passed instead of undefined. I think the cleanest solution is to use an empty string where null was used before.

@Mugen87 Mugen87 added this to the r175 milestone Mar 6, 2025
@Mugen87 Mugen87 merged commit eca7998 into mrdoob:dev Mar 6, 2025
11 checks passed
@s-rigaud s-rigaud deleted the animationclipcreator-default-name branch March 12, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants