Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: fix some errors #30632

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Doc: fix some errors #30632

merged 1 commit into from
Feb 28, 2025

Conversation

s-rigaud
Copy link
Contributor

Description

Fix some errors using TS

Due to #30627, my IDE was able to catch an additionnal arguments passed to ParametricTubeGeometry.

@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.16
78.31		 336.16
78.31		 +0 B
+0 B
WebGPU 522.67
145.12		 522.67
145.12		 +0 B
+0 B
WebGPU Nodes 522.14
145.01		 522.14
145.01		 +0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.22
112.18		 465.22
112.18		 +0 B
+0 B
WebGPU 593.09
160.72		 593.09
160.72		 +0 B
+0 B
WebGPU Nodes 548.22
150.16		 548.22
150.16		 +0 B
+0 B

@Mugen87 Mugen87 added this to the r175 milestone Feb 28, 2025
@Mugen87 Mugen87 merged commit 628fc0d into mrdoob:dev Feb 28, 2025
12 checks passed
@s-rigaud s-rigaud deleted the ts-fix-errors branch March 3, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r175
Development

Successfully merging this pull request may close these issues.
2 participants
@s-rigaud @Mugen87