Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types: fix errors #30665

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Types: fix errors #30665

merged 1 commit into from
Mar 6, 2025

Conversation

s-rigaud
Copy link
Contributor

@s-rigaud s-rigaud commented Mar 6, 2025 •
edited
Loading

Description

Once again, used TypeScript to detect inconcistencies.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.02
78.26		 336.02
78.26		 +0 B
+0 B
WebGPU 523.84
145.45		 523.84
145.45		 +0 B
+0 B
WebGPU Nodes 523.31
145.34		 523.31
145.34		 +0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.06
112.14		 465.06
112.14		 +0 B
+0 B
WebGPU 594.24
161.05		 594.24
161.05		 +0 B
+0 B
WebGPU Nodes 549.37
150.49		 549.37
150.49		 +0 B
+0 B

@Mugen87 Mugen87 added this to the r175 milestone Mar 6, 2025
@Mugen87 Mugen87 merged commit 222a903 into mrdoob:dev Mar 6, 2025
12 checks passed
@s-rigaud s-rigaud deleted the types-fix-erros branch March 12, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r175
Development

Successfully merging this pull request may close these issues.
2 participants
@s-rigaud @Mugen87