Skip to content

GLTFLoader: fix bad reference to PATH_PROPERTIES #30669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025
Merged

GLTFLoader: fix bad reference to PATH_PROPERTIES #30669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions examples/jsm/loaders/GLTFLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2295,7 +2295,7 @@ function addUnknownExtensionsToUserData( knownExtensions, object, objectDef ) {
}

/**
* @param {Object3D|Material|BufferGeometry} object
* @param {Object3D|Material|BufferGeometry|Object} object
* @param {GLTF.definition} gltfDef
*/
function assignExtrasToUserData( object, gltfDef ) {
Expand Down Expand Up @@ -3355,7 +3355,7 @@ class GLTFParser {
* @param {Object} materialParams
* @param {string} mapName
* @param {Object} mapDef
* @param {string} colorSpace
* @param {string} [colorSpace]
* @return {Promise<Texture>}
*/
assignTexture( materialParams, mapName, mapDef, colorSpace ) {
Expand Down Expand Up @@ -3761,7 +3761,7 @@ class GLTFParser {
/**
* Specification: https://github.com/KhronosGroup/glTF/blob/master/specification/2.0/README.md#meshes
* @param {number} meshIndex
* @return {Promise<Group|Mesh|SkinnedMesh>}
* @return {Promise<Group|Mesh|SkinnedMesh|Line|Points>}
*/
loadMesh( meshIndex ) {

Expand Down Expand Up @@ -4463,7 +4463,7 @@ class GLTFParser {
TypedKeyframeTrack = QuaternionKeyframeTrack;
break;

case PATH_PROPERTIES.position:
case PATH_PROPERTIES.translation:
case PATH_PROPERTIES.scale:

TypedKeyframeTrack = VectorKeyframeTrack;
Expand Down
Loading