Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend: Move trackTimestamp to parent class #30714

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Backend: Move trackTimestamp to parent class #30714

merged 1 commit into from
Mar 10, 2025

Conversation

s-rigaud
Copy link
Contributor

Description

trackTimestamp is used for both backends and referenced inside Backend.resolveTimestampsAsync().

@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.02
78.26		 336.02
78.26		 +0 B
+0 B
WebGPU 523.99
145.48		 523.95
145.47		 -42 B
-8 B
WebGPU Nodes 523.46
145.38		 523.42
145.37		 -42 B
-8 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.06
112.14		 465.06
112.14		 +0 B
+0 B
WebGPU 594.38
161.08		 594.33
161.07		 -42 B
-10 B
WebGPU Nodes 549.5
150.51		 549.46
150.5		 -42 B
-10 B

@Mugen87 Mugen87 merged commit 984b00d into mrdoob:dev Mar 10, 2025
12 checks passed
@Mugen87 Mugen87 added this to the r175 milestone Mar 10, 2025
@s-rigaud s-rigaud deleted the move-tracktimestamp-to-backend branch March 12, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r175
Development

Successfully merging this pull request may close these issues.
2 participants
@s-rigaud @Mugen87