Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPUConstants: Fix name of RG11B10UFloat #30717

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

s-rigaud
Copy link
Contributor

Description

WebGPUTextureUtils._getBytesPerTexel() was referencing RG11B10UFloat but the key was misspelled

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.02
78.26
336.02
78.26
+0 B
+0 B
WebGPU 524
145.47
520.4
145.06
-3.6 kB
-412 B
WebGPU Nodes 523.47
145.37
519.87
144.96
-3.6 kB
-411 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.06
112.14
465.06
112.14
+0 B
+0 B
WebGPU 594.39
161.07
590.78
160.69
-3.6 kB
-379 B
WebGPU Nodes 549.51
150.51
545.91
150.13
-3.6 kB
-374 B

@Mugen87 Mugen87 merged commit a94801e into mrdoob:dev Mar 10, 2025
12 checks passed
@Mugen87 Mugen87 added this to the r175 milestone Mar 10, 2025
@s-rigaud s-rigaud deleted the fix-ref-RG11B10uFloat branch March 12, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants