Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MorphNode: Improve performance #30742

Merged
merged 1 commit into from
Mar 16, 2025
Merged

MorphNode: Improve performance #30742

merged 1 commit into from
Mar 16, 2025

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Mar 16, 2025

Related issue: #29980

Description

Do not calculate the morph if the influence is zero, this optimizes vertex calculation.

@sunag sunag added this to the r175 milestone Mar 16, 2025
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.02
78.26
336.02
78.26
+0 B
+0 B
WebGPU 525.04
146.24
525.02
146.24
-20 B
+7 B
WebGPU Nodes 524.5
146.13
524.49
146.14
-20 B
+7 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.06
112.14
465.06
112.14
+0 B
+0 B
WebGPU 597.82
162.5
597.8
162.5
-20 B
+1 B
WebGPU Nodes 552.94
151.98
552.92
151.99
-20 B
+4 B

@sunag sunag marked this pull request as ready for review March 16, 2025 17:48
@sunag sunag merged commit c8daade into mrdoob:dev Mar 16, 2025
12 checks passed
@sunag sunag deleted the dev-vrm branch March 16, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant