Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up. #30752

Merged
merged 1 commit into from
Mar 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions examples/jsm/exporters/GLTFExporter.js
Original file line number Diff line number Diff line change
Expand Up @@ -381,8 +381,8 @@ const GLB_CHUNK_TYPE_BIN = 0x004E4942;
* Compare two arrays
*
* @private
* @param {Array} array1 Array 1 to compare
* @param {Array} array2 Array 2 to compare
* @param {Array} array1 Array 1 to compare
* @param {Array} array2 Array 2 to compare
* @return {boolean} Returns true if both arrays are equal
*/
function equalArray( array1, array2 ) {
Expand All @@ -399,7 +399,7 @@ function equalArray( array1, array2 ) {
* Converts a string to an ArrayBuffer.
*
* @private
* @param {string} text
* @param {string} text
* @return {ArrayBuffer}
*/
function stringToArrayBuffer( text ) {
Expand All @@ -425,9 +425,9 @@ function isIdentityMatrix( matrix ) {
* Get the min and max vectors from the given attribute
*
* @private
* @param {BufferAttribute} attribute Attribute to find the min/max in range from start to start + count
* @param {number} start Start index
* @param {number} count Range to cover
* @param {BufferAttribute} attribute Attribute to find the min/max in range from start to start + count
* @param {number} start Start index
* @param {number} count Range to cover
* @return {Object} Object containing the `min` and `max` values (As an array of attribute.itemSize components)
*/
function getMinMax( attribute, start, count ) {
Expand Down Expand Up @@ -798,7 +798,7 @@ class GLTFWriter {
/**
* Returns ids for buffer attributes.
*
* @param {Object} attribute
* @param {Object} attribute
* @param {boolean} [isRelativeCopy=false]
* @return {number} An integer
*/
Expand Down Expand Up @@ -1053,7 +1053,7 @@ class GLTFWriter {

/**
* Process a buffer to append to the default one.
* @param {ArrayBuffer} buffer
* @param {ArrayBuffer} buffer
* @return {0}
*/
processBuffer( buffer ) {
Expand Down Expand Up @@ -1362,10 +1362,10 @@ class GLTFWriter {

/**
* Process image
* @param {Image} image to process
* @param {number} format Identifier of the format (RGBAFormat)
* @param {boolean} flipY before writing out the image
* @param {string} mimeType export format
* @param {Image} image to process
* @param {number} format Identifier of the format (RGBAFormat)
* @param {boolean} flipY before writing out the image
* @param {string} mimeType export format
* @return {number} Index of the processed texture in the "images" array
*/
processImage( image, format, flipY, mimeType = 'image/png' ) {
Expand Down Expand Up @@ -1484,7 +1484,7 @@ class GLTFWriter {

/**
* Process sampler
* @param {Texture} map Texture to process
* @param {Texture} map Texture to process
* @return {number} Index of the processed texture in the "samplers" array
*/
processSampler( map ) {
Expand All @@ -1506,7 +1506,7 @@ class GLTFWriter {

/**
* Process texture
* @param {Texture} map Map to process
* @param {Texture} map Map to process
* @return {Promise<number>} Index of the processed texture in the "textures" array
*/
async processTextureAsync( map ) {
Expand Down Expand Up @@ -1552,7 +1552,7 @@ class GLTFWriter {

/**
* Process material
* @param {THREE.Material} material Material to process
* @param {THREE.Material} material Material to process
* @return {Promise<number|null>} Index of the processed material in the "materials" array
*/
async processMaterialAsync( material ) {
Expand Down Expand Up @@ -1728,7 +1728,7 @@ class GLTFWriter {

/**
* Process mesh
* @param {THREE.Mesh} mesh Mesh to process
* @param {THREE.Mesh} mesh Mesh to process
* @return {Promise<number|null>} Index of the processed mesh in the "meshes" array
*/
async processMeshAsync( mesh ) {
Expand Down Expand Up @@ -2133,7 +2133,7 @@ class GLTFWriter {

/**
* Process camera
* @param {THREE.Camera} camera Camera to process
* @param {THREE.Camera} camera Camera to process
* @return {number} Index of the processed mesh in the "camera" array
*/
processCamera( camera ) {
Expand Down Expand Up @@ -2334,7 +2334,7 @@ class GLTFWriter {

/**
* Process Object3D node
* @param {THREE.Object3D} object Object3D to processNodeAsync
* @param {THREE.Object3D} object Object3D to processNodeAsync
* @return {Promise<number>} Index of the node in the nodes list
*/
async processNodeAsync( object ) {
Expand Down Expand Up @@ -2442,7 +2442,7 @@ class GLTFWriter {

/**
* Process Scene
* @param {Scene} scene Scene to process
* @param {Scene} scene Scene to process
*/
async processSceneAsync( scene ) {

Expand Down Expand Up @@ -2486,7 +2486,7 @@ class GLTFWriter {

/**
* Creates a Scene to hold a list of objects and parse it
* @param {Array<THREE.Object3D>} objects List of objects to process
* @param {Array<THREE.Object3D>} objects List of objects to process
*/
async processObjectsAsync( objects ) {

Expand Down
2 changes: 1 addition & 1 deletion examples/jsm/loaders/GLTFLoader.js
Original file line number Diff line number Diff line change
Expand Up @@ -3587,7 +3587,7 @@ class GLTFParser {
* be created if necessary, and reused from a cache.
*
* @private
* @param {Object3D} mesh Mesh, Line, or Points instance.
* @param {Object3D} mesh Mesh, Line, or Points instance.
*/
assignFinalMaterial( mesh ) {

Expand Down
4 changes: 2 additions & 2 deletions src/nodes/core/StackNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ class StackNode extends Node {
* @function
* @deprecated since r168. Use {@link StackNode#Else} instead.
*
* @param {...any} params
* @param {...any} params
* @returns {StackNode}
*/
else( ...params ) { // @deprecated, r168
Expand All @@ -180,7 +180,7 @@ class StackNode extends Node {
/**
* @deprecated since r168. Use {@link StackNode#ElseIf} instead.
*
* @param {...any} params
* @param {...any} params
* @returns {StackNode}
*/
elseif( ...params ) { // @deprecated, r168
Expand Down
8 changes: 4 additions & 4 deletions src/nodes/display/BlendModes.js
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export const blendColor = /*@__PURE__*/ Fn( ( [ base, blend ] ) => {
* @function
* @deprecated since r171. Use {@link blendBurn} instead.
*
* @param {...any} params
* @param {...any} params
* @returns {Function}
*/
export const burn = ( ...params ) => { // @deprecated, r171
Expand All @@ -152,7 +152,7 @@ export const burn = ( ...params ) => { // @deprecated, r171
* @function
* @deprecated since r171. Use {@link blendDodge} instead.
*
* @param {...any} params
* @param {...any} params
* @returns {Function}
*/
export const dodge = ( ...params ) => { // @deprecated, r171
Expand All @@ -167,7 +167,7 @@ export const dodge = ( ...params ) => { // @deprecated, r171
* @function
* @deprecated since r171. Use {@link blendScreen} instead.
*
* @param {...any} params
* @param {...any} params
* @returns {Function}
*/
export const screen = ( ...params ) => { // @deprecated, r171
Expand All @@ -182,7 +182,7 @@ export const screen = ( ...params ) => { // @deprecated, r171
* @function
* @deprecated since r171. Use {@link blendOverlay} instead.
*
* @param {...any} params
* @param {...any} params
* @returns {Function}
*/
export const overlay = ( ...params ) => { // @deprecated, r171
Expand Down
2 changes: 1 addition & 1 deletion src/nodes/math/ConditionalNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ addMethodChaining( 'select', select );
* @function
* @deprecated since r168. Use {@link select} instead.
*
* @param {...any} params
* @param {...any} params
* @returns {ConditionalNode}
*/
export const cond = ( ...params ) => { // @deprecated, r168
Expand Down
2 changes: 1 addition & 1 deletion src/nodes/math/OperatorNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -637,7 +637,7 @@ addMethodChaining( 'shiftRight', shiftRight );
* @function
* @deprecated since r168. Use {@link modInt} instead.
*
* @param {...any} params
* @param {...any} params
* @returns {Function}
*/
export const remainder = ( ...params ) => { // @deprecated, r168
Expand Down
2 changes: 1 addition & 1 deletion src/nodes/tsl/TSLCore.js
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,7 @@ export const Fn = ( jsFunc, nodeType ) => {
* @function
* @deprecated since r168. Use {@link Fn} instead.
*
* @param {...any} params
* @param {...any} params
* @returns {Function}
*/
export const tslFn = ( ...params ) => { // @deprecated, r168
Expand Down
2 changes: 1 addition & 1 deletion src/nodes/utils/LoopNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ export const Break = () => expression( 'break' ).append();
* @function
* @deprecated since r168. Use {@link Loop} instead.
*
* @param {...any} params
* @param {...any} params
* @returns {LoopNode}
*/
export const loop = ( ...params ) => { // @deprecated, r168
Expand Down
Loading