Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSL: Fix equal() inconsistent #30777

Merged
merged 2 commits into from
Mar 22, 2025
Merged

TSL: Fix equal() inconsistent #30777

merged 2 commits into from
Mar 22, 2025

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Mar 21, 2025

Fixes #30755

Description

Fix equality operator consistency since in WGSL it returns a vector and in GLSL a boolean thus deprecating equals() making it simpler and similar to GLSL.

@sunag sunag added this to the r175 milestone Mar 21, 2025
Copy link

github-actions bot commented Mar 21, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.08
78.29
336.08
78.29
+0 B
+0 B
WebGPU 526.03
146.59
526.26
146.63
+231 B
+38 B
WebGPU Nodes 525.5
146.49
525.73
146.52
+231 B
+38 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.15
112.18
465.15
112.18
+0 B
+0 B
WebGPU 598.23
162.62
598.46
162.66
+228 B
+42 B
WebGPU Nodes 553.32
152.09
553.54
152.12
+228 B
+25 B

@sunag sunag marked this pull request as ready for review March 21, 2025 20:11
@sunag sunag merged commit 51856a6 into mrdoob:dev Mar 22, 2025
12 checks passed
@sunag sunag deleted the dev-equal branch March 22, 2025 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSL : vec4.equal return vec4<bool> instead of bool
1 participant