CapsuleGeometry: Add heightSegments parameter #30868
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
| */ | ||
| constructor( radius = 1, length = 1, capSegments = 4, radialSegments = 8 ) { | ||
| constructor( radius = 1, length = 1, capSegments = 4, radialSegments = 8, heightSegments = 1 ) { |
There was a problem hiding this comment.
Why heightSegments? Why not lengthSegments
There was a problem hiding this comment.
If anything I would think length should change to height, and that would be a useful change.
Looking at other geometries:
BoxGeometry -> height
ConeGeometry -> height
CylinderGeometry -> height
and so on, with heightSegments, etc.
height would be more consistent within itself and other components. I'll make that change.
There was a problem hiding this comment.
I vote to stick to the height notation in this case.
|
UVs may not be correct. I would not expect the texture to appear differently when tessellations are increased. Also, perhaps unrelated to this PR, the number of segments in the caps appears to be twice the number specified. |
I agree with that, and will change that. Looking at UVs closer, there are issues prior to this patch with UVs (as you vary
Yes that happens before this patch, but I can fix. -- I do have a question of UV strategy before I implement. I think an even UV distribution along the total curve length makes the most sense, but other methods could work. Any objections to that? |
It might be easier, and adequate, to make an even distribution of UV along the total height. (Also likely easier to create a custom texture in that case.) |
Ask @Mugen87. That would be a breaking change, and I am not sure it is worth it. Regardless, I will support his decision on that. |
Yes, I think that should be fixed even if it breaks a user setup. The migration task to restore the previous visual should be trivial. But let's do this with a different PR. |
|
I would also say the texture coordinate issue should be tackled with a different PR. Maybe a fix is required in |
Description
The
CapsuleGeometrywas missing a parameter for controlling segments along the height, useful/critical for shaders. This adds aheightsParametermatchingCylinderGeometry, etc.