Skip to content

RenderTarget: Fix depth texture assignment regression. #30921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2025

Conversation

Spiri0
Copy link
Contributor

@Spiri0 Spiri0 commented Apr 13, 2025

I fixed a small bug in RenderTarget.js. I corrected the usage of depthTexture assignment in the RenderTarget constructor. Now using the setter function again like in r174 and before. The setter ensure the correct _depthTexture assignment and proper renderTarget linkage.

Fixed #30895

A lot of changes were made in #30633, and this may have gotten lost

…ture assignment in the RenderTarget constructor. Now using the setter function again like in r174 and before to ensure renderTarget is properly linked to the texture
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.49
78.38
336.49
78.38
+0 B
+0 B
WebGPU 542.05
150.13
542.05
150.13
+0 B
+0 B
WebGPU Nodes 541.51
150.03
541.51
150.03
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.42
112.22
465.45
112.23
+23 B
+4 B
WebGPU 614.89
166.17
614.91
166.18
+23 B
+3 B
WebGPU Nodes 569.88
155.58
569.9
155.59
+23 B
+4 B

@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 13, 2025

Good catch!

@Mugen87 Mugen87 merged commit 8a812ee into mrdoob:dev Apr 13, 2025
12 checks passed
@Mugen87 Mugen87 added this to the r176 milestone Apr 13, 2025
@Mugen87 Mugen87 changed the title Fix a small bug in RenderTarget.js RenderTarget: Fix depth texture assignment regression. Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r175 breaks custom shadow because RenderTarget changed to multisampled
2 participants