Skip to content

Search DLLs only on paths added using add_dll_directory(). #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

naveen521kk
Copy link
Member

This is the default behavior on upstream Python. We previously reverted this behavior because it broke some use cases.

The old behavior can be restored by setting the environment variable PYTHONLEGACYWINDOWSDLLLOADING to 1.

Fixes #48
Also fixes #141

This is the default behavior on upstream Python. We previously
reverted this behavior because it broke some use cases.

The old behavior can be restored by setting the environment variable
PYTHONLEGACYWINDOWSDLLLOADING to 1.

Fixes msys2-contrib#48
Also fixes msys2-contrib#141

Signed-off-by: Naveen M K <[email protected]>
@lazka
Copy link
Member

lazka commented Aug 5, 2023

lgtm

@naveen521kk naveen521kk merged commit 2b2d1a5 into msys2-contrib:mingw-v3.11.4 Aug 6, 2023
@naveen521kk naveen521kk deleted the fix-dll-loading branch August 6, 2023 07:26
lazka pushed a commit to msys2/MINGW-packages that referenced this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading _sqlite3 fails with MSYSTEM not set and /bin not in PATH Remove workaround to support AddDllDirectory
2 participants