Use penthouse from npm #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebm
force-pushed
the
penthouse-npm
branch
11 times, most recently
from
29c52c7 to
9ca9964
Compare
1. Install npm dependencies on Gem.pre_install. 2. Use a penthouse wrapper script. 3. Remove phantomjs ruby dependency and the vendored version of penthouse. 4. Add a basic test. Refs mudbugmedia#5
|
Good news! I finally got a chance to test this out. After some changes to my local environment and minor code changes, I was able to get this working as expected. I'll commit the code changes necessary as soon as I can. However, I wasn't able to get the gemspec extensions script working: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gem.pre_install.Refs #5