Fixed Issue with MCP3xxx Sensors #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added stacktraces without interrupting/exiting whenever a KeyError while reading the config occurs. Added traceback to the imports
Fixed an Issue where a correct configuration with an MCP3008 worker and a Soil Sensor resulted in KeyErrors. Internal pin reference is now made by int's.
olixr
reviewed
Apr 23, 2020
olixr
approved these changes
Apr 23, 2020
olixr
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MCP3xxx KeyError
There was a contradiction of the Pins of the MCP3xxx being specified as strings while the input was always casted to int.
The Pins are now referenced internally via Integer and correctly cast strings (containing numbers) to it. No Config change should be needed.
KeyErrors in mudpi.py
Also added stack traces to be printed for many KeyErrors inside
mudpi.pyto help with future troubleshooting.This will not interrupt the program though and introduced
tracebackas an import.I've also omitted keys like
'camera'as they are no list that can be kept empty.