Skip to content

Fix #25973 reset page number when resetting page settings #27392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

luisastark
Copy link

Resetting all page settings to default wasn't resetting the first page number. Fixed this issue by setting the index of the first page to 1 when resetting a page to default.

Resolves: #25973

When resetting all page settings to default, it was only resetting the values of the buttons in inches and nowhere in the code did it reset the page index number. I added the code that resets the page number to 1 when clicking the "reset all page settings to default" to fix this issue.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

Resetting all page settings to default wasn't resetting the first page
number. Fixed this issue by setting the index of the first page to 1
when resetting a page to default.
@oktophonie oktophonie requested a review from cbjeukendrup April 7, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reset all page settings to default doesn't reset first page number
1 participant