-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MusicXML] invisible notations #27422
base: master
Are you sure you want to change the base?
Conversation
src/importexport/musicxml/internal/musicxml/import/importmusicxmlpass2.cpp
Outdated
Show resolved
Hide resolved
Backport of musescore#27422
Seems |
No, still needed, because it is generally impossible to mark directions as invisible. |
Hmm, where on export is the actual hiding done? Removing the calls to |
It is done here and was there all the time: MuseScore/src/importexport/musicxml/internal/musicxml/export/exportmusicxml.cpp Lines 610 to 626 in 7b242c3
|
Ah, I see. Missing in 3.x... |
Backport of musescore#27422
f8bf231
to
d420f6f
Compare
Backport of musescore#27422
Backport of musescore#27422
Backport of musescore#27422
Backport of musescore#27422
Backport of musescore#27422
Backport of musescore#27422
Backport of musescore#27422
Backport of musescore#27422
Backport of musescore#27422
This adds proper import and export for invisible
notations
from MusicXML.NB: I think the original intention of
exportInvisibleElements
was to allow exporting invisible elements that can not be marked as invisible in MusicXML. However the current solution showed weird inconsitencies when making all elements in a measure invisible. With this approach invisble notations are correctly exported and imported.