Improve horizontal spacing performance by up to 70% if systems are locked #27512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know how this didn't occur to me before. The main thing that's expensive about horizontal spacing is that we need to update it measure by measure as we add measures to the system, in order to update the resulting system width and therefore decide how many measures to fit (i.e. where to break the line). But if a system is locked that's not necessary, because the line breaking decision is not up to us, which means we can skip all the intermediate calculations and just continue adding measures until the last measure of the current lock. This saves approximately 2/3 of the computation time.
Horizontal spacing only accounts for a relatively small part of the whole layout computation time, so it's not like this is going make a massive difference in the user experience. Still, in my test file (orchestral piece with all parts generated and all systems locked both in score and in parts) this saved 9-10% of the total layout time, not too bad.