Fix porting error #27567
Merged
Fix porting error #27567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oktophonie
approved these changes
Apr 7, 2025
miiizen
approved these changes
Apr 7, 2025
github-project-automation
bot
moved this from In Progress
to Needs porting
in MuseScore Studio 4.5.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happened because some code has been merged in master but not in 4.5 related to fret diagrams, which means that my recent PR about this (which worked in master) didn't port properly to 4.5.2 and the vtests failure for 4.5.2 wasn't spotted because they were supposed to fail anyway. @miiizen @oktophonie let's remind ourselves to always re-check the vtests and not take them for granted when porting things between branches.