Skip to content

Commit 16d20ad

Browse files
authored
fix: add missing types for encoding tier, generated subtitles settings and multi-track audio (#319)
* fix: add missing types for encoding tier & generated subtitles settings * fix: allow type to be 'text' or 'audio' and now text_type is optional because you don't pass text_type for multi-track audio
1 parent 5062cc7 commit 16d20ad

File tree

3 files changed

+12
-4
lines changed

3 files changed

+12
-4
lines changed

src/video/domain.ts

+10-2
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,12 @@ export interface InputOverlaySettings {
7979
opacity?: string;
8080
}
8181

82+
export interface GeneratedSubtitlesSettings {
83+
name?: string;
84+
passthrough?: string;
85+
language_code?: string;
86+
}
87+
8288
export interface InputSettings {
8389
url: string;
8490
start_time?: number;
@@ -90,6 +96,7 @@ export interface InputSettings {
9096
name?: string;
9197
closed_captions?: boolean;
9298
passthrough?: string;
99+
generated_subtitles?: Array<GeneratedSubtitlesSettings>;
93100
}
94101

95102
export interface CreateAssetParams {
@@ -102,6 +109,7 @@ export interface CreateAssetParams {
102109
master_access?: AssetMasterAccess;
103110
per_title_encode?: boolean;
104111
max_resolution_tier?: '1080p' | '1440p' | '2160p';
112+
encoding_tier?: 'baseline' | 'smart';
105113
}
106114

107115
export interface UpdateAssetParams {
@@ -209,8 +217,8 @@ export interface CreatePlaybackIdParams {
209217

210218
export interface CreateTrackParams {
211219
url: string;
212-
type: 'text';
213-
text_type: 'subtitles';
220+
type: 'text' | 'audio';
221+
text_type?: 'subtitles';
214222
language_code: string;
215223
name?: string;
216224
closed_captions?: boolean;

src/video/resources/assets.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ export class Assets extends Base {
265265
}
266266

267267
if (!params) {
268-
return Promise.reject(new Error('Text track params are required'));
268+
return Promise.reject(new Error('Track params are required'));
269269
}
270270
return this.http.post(`${buildBasePath(assetId)}/tracks`, params);
271271
}

test/unit/video/resources/assets.spec.cjs

+1-1
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ describe('Unit::Assets', () => {
235235
})
236236
.catch((err) => {
237237
expect(err).to.exist;
238-
expect(err.message).to.equal('Text track params are required');
238+
expect(err.message).to.equal('Track params are required');
239239
}));
240240
});
241241

0 commit comments

Comments
 (0)