fix: add missing types for encoding tier & generated subtitles settings #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsanford8
approved these changes
Nov 8, 2023
dylanjha
commented
Nov 8, 2023
| name?: string; | ||
| passthrough?: string; | ||
| language_code?: string; | ||
| } |
There was a problem hiding this comment.
interestingly none of these are actually required. This request:
{
"playback_policy": [
"public"
],
"input": [
{
"url": "https://muxed.s3.amazonaws.com/leds.mp4",
"generated_subtitles": [
{}
]
}
]
}Will result in a text track being created with default language_code: "en" and default name: "English CC"
{
"type": "text",
"text_type": "subtitles",
"text_source": "generated_vod",
"status": "preparing",
"name": "English CC",
"language_code": "en",
"id": "zHkS8uZkPyY5v45ixKB3pgF8DEZyJrj5P2Nd7bZg2GidHOAyQX6rFQ"
}… because you don't pass text_type for multi-track audio
dylanjha
force-pushed
the
dj/new-params
branch
from
bd2203a to
4eba4dc
Compare
jsanford8
approved these changes
Nov 8, 2023
Merged
Merged
jsanford8
pushed a commit
that referenced
this pull request
Feb 25, 2025
* chore: rebuild project due to codegen change (#523) * docs: remove suggestion to use `npm` call out (#525) * chore: remove redundant word in comment (#526) * feat(internal): make git install file structure match npm (#527) * chore(internal): remove unnecessary getRequestClient function (#528) * chore(internal): bump cross-spawn to v7.0.6 (#529) Note: it is a dev transitive dependency. * chore(types): nicer error class types + jsdocs (#530) * chore(internal): update isAbsoluteURL (#531) * feat: generate more types that are used as request bodies (#532) * feat(api): api update (#533) * trigger CI * chore(internal): fix some typos (#534) * codegen metadata * fix(client): normalize method (#535) * feat: Add video.asset.non_standard_input_detected webhook (#317) (#536) * docs: minor formatting changes (#537) * chore(internal): codegen related update (#538) * chore(internal): codegen related update (#539) * chore(internal): codegen related update (#541) * feat(client): send `X-Stainless-Timeout` header (#542) * feat: Add passthrough field on static renditions (#320) (#543) * feat: Additional Standard Dimensions (#319) (#544) * fix(client): fix export map for index exports (#545) * chore!: deprecate `mp4_support` option (#321) (#547) * chore(internal): fix devcontainers setup (#548) * codegen metadata * release: 10.0.0 --------- Co-authored-by: stainless-app[bot] <142633134+stainless-app[bot]@users.noreply.github.com> Co-authored-by: Samuel El-Borai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.