Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run tests on Django 2.2 #145

Merged
merged 5 commits into from
Nov 6, 2019
Merged

run tests on Django 2.2 #145

merged 5 commits into from
Nov 6, 2019

Conversation

tisdall
Copy link
Contributor

@tisdall tisdall commented Sep 5, 2019

No description provided.

@coveralls
Copy link

coveralls commented Sep 5, 2019

Coverage Status

Coverage remained the same at 83.882% when pulling 9e8795f on tisdall:update_tox into b8aaa47 on mwarkentin:master.

@tisdall
Copy link
Contributor Author

tisdall commented Sep 5, 2019

It seems PyMySQL has issues with Django 2.2 and isn't supported.

@tisdall
Copy link
Contributor Author

tisdall commented Sep 6, 2019

If I change the 'requirements-test.txt' to use mysqlclient>=1.3.13 it should solve the issue. However, it seems PyMySQL was chosen for a reason (from the notes in the file). From what I've read, it doesn't look like there's a way to get PyMySQL to work with Django 2.2 (due to it switching to using bytes instead of str).

Here's the exception on the failed check:
django.core.exceptions.ImproperlyConfigured: mysqlclient 1.3.13 or newer is required; you have 0.9.3.

@stale
Copy link

stale bot commented Nov 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 5, 2019
@stale stale bot removed the stale label Nov 5, 2019
@mwarkentin
Copy link
Owner

According to PyMySQL/PyMySQL#790 (comment) this should be fixed for Django 3.0, although I wasn't able to figure out what fix he was actually referring to.

@tisdall
Copy link
Contributor Author

tisdall commented Nov 5, 2019

Travis seems to have support for the C libraries needed for mysqlclient so I switched it over to use it and now the tests pass. Django 2.2 specifically says to use mysqlclient and I don't think things are going to be fixed in PyMySQL to support Django 2.2 (which is a LTS version).

Copy link
Owner

@mwarkentin mwarkentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mwarkentin mwarkentin merged commit b26db52 into mwarkentin:master Nov 6, 2019
@tisdall tisdall deleted the update_tox branch December 17, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants