-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run tests on Django 2.2 #145
Conversation
It seems PyMySQL has issues with Django 2.2 and isn't supported. |
If I change the 'requirements-test.txt' to use Here's the exception on the failed check: |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
According to PyMySQL/PyMySQL#790 (comment) this should be fixed for Django 3.0, although I wasn't able to figure out what fix he was actually referring to. |
Travis seems to have support for the C libraries needed for mysqlclient so I switched it over to use it and now the tests pass. Django 2.2 specifically says to use mysqlclient and I don't think things are going to be fixed in PyMySQL to support Django 2.2 (which is a LTS version). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
No description provided.