Throw Exception when adding @AutomapConstructor to multiple constructors #2627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstructor can only be used in one constructor.
harawata
requested changes
Jul 29, 2022
There was a problem hiding this comment.
Thank you for the PR, @sogoagain !
Actually, this problem is not affected by the argNameBasedConstructorAutoMapping setting, so could you please move the test case to org.apache.ibatis.autoconstructor ?
If you are busy, please just let me know and I'll take care of it when I have time.
| throw new ExecutorException("@AutomapConstructor should be used in only one constructor."); | ||
| } | ||
| if (automapConstructors.size() == 1) { | ||
| return Optional.of(automapConstructors.get(0)); | ||
| } | ||
| if (configuration.isArgNameBasedConstructorAutoMapping()) { |
There was a problem hiding this comment.
How about using reduce?
return Arrays.stream(constructors)
.filter(x -> x.isAnnotationPresent(AutomapConstructor.class))
.reduce((x, y) -> {
throw new ExecutorException("@AutomapConstructor should be used in only one constructor.");
}).or(() -> {
if (configuration.isArgNameBasedConstructorAutoMapping()) {
...It probably is a matter of preference, so if you don't like it, the current version is fine. :)
There was a problem hiding this comment.
It looks very good! thank you.
sogoagain
changed the title
sogoagain
changed the title
|
@harawata Thanks for the review! I understood and moved the test code package. also edited the PR title and content. |
- or() requires Java 9 - License years
harawata
approved these changes
Jul 31, 2022
sogoagain
deleted the
arg-name-based-constructor-automapping-only-one-automap-constructor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2626
Provides helpful error messages when adding @AutomapConstructor to multiple constructors.
thank you.