-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Support java.util.Optional as return type of mapper method #799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support java.util.Optional as return type of mapper method #799
Conversation
4eca279
to
d4099b7
Compare
d4099b7
to
452ba6b
Compare
Hi, I wrote a patch to support Optional, a while ago. I consider it is still under the committers' review (@eddumelendez seemed to like it), but I would appreciate if you could check it out and let me know what you think. Thank you, |
Hi @harawata, it's great !! I will confirm your patch at later and leave comments if needed. Thanks ! |
# Conflicts: # src/main/java/org/apache/ibatis/binding/MapperMethod.java
Hi @kazuki43zoo , Do you mind if I add some commits to this PR? |
@kazuki43zoo , I have added a few commits (hope it was OK!). @jeffgbutler @christianpoitras To reduce the noise, it's better to add |
This reverts commit 9ce0fcd.
@harawata Thanks for your improvements. I feel your changes are good! |
…s an array with one element here, I think.
Hello, I'm curious: is there a timeline for the acceptance and release of this pull request? |
All changes seem fine. @harawata, you can merge the pull request. |
Thanks @christianpoitras ! |
Thanks @christianpoitras and @harawata - I am looking forward to using it. |
…er-method Support java.util.Optional as return type of mapper method
I know this fix is ad hoc. However, i want to provide early this feature for Java 8 users. I will improve this feature at 3.5 or later version.
This fix allow following method definition:
Please review.