Skip to content

Update dependency maven-wrapper to v3.3.0 #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 20, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
maven-wrapper 3.2.0 -> 3.3.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 6e7d957 on renovate/maven-wrapper-3.x
into 5328256 on master.

@jeffgbutler jeffgbutler merged commit 094786b into master Apr 21, 2024
9 of 10 checks passed
@renovate renovate bot deleted the renovate/maven-wrapper-3.x branch April 21, 2024 12:29
public static void main( String[] args ) throws Exception
{
setDefault( new Downloader() );
java.nio.file.Files.copy( new java.net.URL( args[0] ).openStream(), java.nio.file.Paths.get( args[1] ).toAbsolutePath().normalize() );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffgbutler Just a heads up. Something is off with Renovate on the wrapper patches. Line 202 here was updated by maven as part of the release to use URI instead of deprecated constructor from URL. While renovate does switch the default used (source) to another so it misses files we have been using, its somehow also applying wrong version. I saw PRs on some repos reapply version 3.2.0 during this process (only noted since I make the apache license urls https). All others are doing this. I looked around renovates code but didn't quite figure out what they were doing. I've double checked what maven deployed to central and they certainly did not deploy this. Since i have to patch anyways, another PR will come in that looks to be a large scale change which ends up fixing this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hazendaz Thanks for being on top of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants