Skip to content

Support CASE Expressions in ORDER BY Phrases #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 6, 2024

Conversation

jeffgbutler
Copy link
Member

This PR has two main features:

  1. Rendering of ORDER BY phrases is refactored to allow access to the parameter map by implementing a more general renderForOrderBy method that returns FragmentAndParameters. Any user provided implementations of SortSpecification will be affected - two existing methods are deprecated in favor of the new rendering strategy.
  2. Case expressions are updated to support their inclusion in an order by phrase
  3. The PR also includes several code cleanup items after the move to Java 17

Resolves #821

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling dca5d3d on jeffgbutler:case-in-order-by
into 028da50 on mybatis:master.

@jeffgbutler jeffgbutler added this to the 2.0.0 milestone Aug 6, 2024
@jeffgbutler jeffgbutler merged commit e2d75aa into mybatis:master Aug 6, 2024
7 checks passed
@jeffgbutler jeffgbutler deleted the case-in-order-by branch August 6, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function or statement for Order by clauses
2 participants