-
Notifications
You must be signed in to change notification settings - Fork 3
Exports and export assignments are not permitted in module augmentations #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi, @beastlyDartfordian. Thanks for reporting it. I'm planning to update the project to version 2 to resolve this, but I haven't discussed it with the maintainers yet. It's a conflict that I already imagined could happen when we need to export both “default” to “named”, but for the first version the idea was not to think about the name of the exported methods. See #5. I also tried this simple approach to avoid a bc so soon: #23 (comment), but without success. |
In parallel with resolving this issue, I thought about something that would be interesting for this project (in future) and would make it even lighter and more flexible for end users. Currently we manually adapt the certificates into an array and use everything together, but we could use a simple builder to use the
Note The Regarding the name, the end user could rename it both for CJS and ESM, for example: const { awsCaBundle: ssl } = require('aws-ssl-profiles'); import { awsCaBundle as ssl } from 'aws-ssl-profiles'; What do you think? 🙋🏻♂️ |
As you work on version 2, can this still be fixed for version 1 in the meantime by doing what I recommended here? #23 (comment) If not I can just spin up a PR this week to quickly patch this bug with a version 1.1.2 or something |
Hey @HappyZombies, thanks for the ping 🙋🏻♂️
|
Hello,
when running pnpm build on my project while using [email protected] I get the following error:
node_modules/.pnpm/[email protected]/node_modules/aws-ssl-profiles/lib/index.d.ts:6:5 - error TS2666: Exports and export assignments are not permitted in module augmentations.
6 export = profiles;
Found 1 error in node_modules/.pnpm/[email protected]/node_modules/aws-ssl-profiles/lib/index.d.ts:6
The text was updated successfully, but these errors were encountered: