-
Notifications
You must be signed in to change notification settings - Fork 3
fix: resolve imports manually #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@wellwelwel this ended up being a breaking change for how I was using the module. version 1.0.0, I had this const { ca: awsCa } = require('aws-ssl-profiles').default; With version 1.1.1, I get this error now. const { ca: awsCa } = require('aws-ssl-profiles').default;
|
Hi @HappyZombies, thanks for the report. I'll take a look at it. In theory, this should work: Line 13 in d8f28d3
But unfortunately, there are several bugs when using both If this can't be resolved, I think it would be better to release a |
Ah I see, I think simply adding: module.exports.default = profiles; Should fix this for it to be non breaking change, no? |
Resolves a common conflict when the same file has multiple import types for both ESM and CJS.