Add Pool connection event, which fires when the Pool has created a new connection

[marcuswestin]

This allows for e.g. setting Session variables on the connection before it gets used

[felixge]

Thx. LGTM. Feel free to merge.

[dougwilson]

@marcuswestin I just noticed this, but your connection event emits two arguments: err and connection. This seems weird, as I don't know any event signature in node that looks like that. IMO the event should only emit connection.

this.emit('connection', connection); 

It would be nice if you changed it before release (: If in the future it is ever wanted to emit the error connecting, that would be what the error event if for (or even a connectionError event if you want it to be ignorable/specific).

[marcuswestin]

Good point, will change.
-- while mobile

On Tue, May 14, 2013 at 8:53 AM, Douglas Christopher Wilson
[email protected] wrote:

@marcuswestin I just noticed this, but your connection event emits two arguments: err and connection. This seems weird, as I don't know any event signature in node that looks like that. IMO the event should only emit connection.

this.emit('connection', connection); 

It would be nice if you changed it before release (: If in the future it is ever wanted to emit the error connecting, that would be what the error event if for (or even a connectionError event if you want it to be ignorable/specific).

Reply to this email directly or view it on GitHub:
#486 (comment)

[felixge]

@dougwilson great catch, didn't spot this! Thanks.