Add an option to run golangci-lint from the directory of config file #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will gladly remove the option and make |
golangci-lint has issues running in subdirectories of the project, e.g. golangci/golangci-lint#3656, golangci/golangci-lint#3717, so running it from the directory where configuration file is located is the only option for some projects. Make it work as an option, because not every project triggers this problem in golangci-lint, so for these projects overhead of looking up directory of config file and adjusting the paths after is not needed.
misha-ridge
force-pushed
the
add-run-from-config-dir
branch
from
478554e to
7429faf
Compare
|
i'd really like this feature |
|
I initially thought this was an issue on the golangci-lint side, but I’m open to considering it. I’ve added integration tests in handler_test.go. Please include a test case for the situation you’re addressing in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golangci-lint has issues running in subdirectories of the project, e.g. golangci/golangci-lint#3656, golangci/golangci-lint#3717, so running it from the directory where configuration file is located is the only option for some projects.
Make it work as an option, because not every project triggers this problem in golangci-lint, so for these projects overhead of looking up directory of config file and adjusting the paths after is not needed.