Skip to content

fix: correctly search for the tab fragment #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions src/core-tabs/tab-content-item/index.android.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { GridLayout, View } from '@nativescript/core';
import { GridLayout, View, Trace } from '@nativescript/core';
import { TabContentItem as TabContentItemDefinition } from '.';
import { TabContentItemBase } from './tab-content-item-common';

Expand Down Expand Up @@ -37,20 +37,30 @@ export class TabContentItem extends TabContentItemBase {
(this as TabContentItemDefinition).canBeLoaded = false;
}

_getChildFragmentManager() {
const tabView = this.parent as View;
let tabFragment = null;
const fragmentManager = tabView._getFragmentManager();
private _fragmentMatches(fragment: any) {
// ensure index AND owner for when 2 tabviews are in the same page
return fragment.index === this.index && fragment.owner === this.parent;
}
private _findFragment(fragmentManager: androidx.fragment.app.FragmentManager) {
if (!fragmentManager) {
return null;
}
const fragments = fragmentManager.getFragments().toArray();
for (let i = 0; i < fragments.length; i++) {
// ensure index AND owner for when 2 tabviews are in the same page
if (fragments[i].index === this.index && fragments[i].owner === tabView) {
tabFragment = fragments[i];
break;
if (fragments[i].index === this.index && fragments[i].owner === this.parent) {
return fragments[i];
}
}
return null;
}

_getChildFragmentManager() {
const tabView = this.parent as View;
let tabFragment = null;
tabFragment = this._findFragment(tabView._getRootFragmentManager()) || this._findFragment(tabView._getFragmentManager());
if (!tabFragment) {
return fragmentManager;
Trace.write(`No fragment found for ${tabView} with index ${this.index}`, Trace.categories.Error, Trace.messageType.error);
return tabView._getFragmentManager();
}
return tabFragment.getChildFragmentManager();
}
Expand Down