Skip to content

Fix accessing this.$refs.foo if component is declared with ref="foo" #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 7, 2019

Conversation

msaelices
Copy link

Fix #543

@msaelices msaelices requested a review from rigor789 September 5, 2019 16:56
@codecov-io
Copy link

codecov-io commented Sep 5, 2019

Codecov Report

Merging #544 into master will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #544      +/-   ##
==========================================
+ Coverage   13.64%   13.67%   +0.03%     
==========================================
  Files          49       49              
  Lines        1246     1243       -3     
  Branches      308      308              
==========================================
  Hits          170      170              
+ Misses        844      841       -3     
  Partials      232      232
Impacted Files Coverage Δ
platform/nativescript/runtime/components/frame.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd9a1a3...681aa6d. Read the comment docs.

@rigor789 rigor789 merged commit 4872304 into master Sep 7, 2019
@msaelices msaelices deleted the fix-undefined-refs branch September 8, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

We cannot reference any NS-Vue component within the code
3 participants