Skip to content

chore(docs): Migrating from Apollo Guide #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 13, 2019
Merged

Conversation

bmullan91
Copy link
Contributor

@bmullan91 bmullan91 commented Mar 12, 2019

What does this PR do?

Provides a complete guide on how to migrate from apollo ➡️graphql-hooks. Rendered output: https://github.com/nearform/graphql-hooks/blob/70c9242f7817188611d31ba539f1bda41df23725/README.md

TODOs

  • <Mutation /> ➡️useMutation() guide

Related issues

Fixes #28

Checklist

  • I have checked the contributing document
  • I have added or updated any relevant documentation
  • I have added or updated any relevant tests

@bmullan91 bmullan91 force-pushed the guide_migrating_from_apollo branch from 532fbfe to ec203c2 Compare March 12, 2019 23:21
@bmullan91 bmullan91 marked this pull request as ready for review March 13, 2019 00:11
@bmullan91 bmullan91 requested review from jackdclark and Joezo March 13, 2019 00:13
@bmullan91 bmullan91 force-pushed the guide_migrating_from_apollo branch from bd5e5ac to e57b086 Compare March 13, 2019 12:08
Copy link
Contributor

@jackdclark jackdclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @bmullan91, a few minor changes/suggestions but will approve once addressed 👏

@bmullan91 bmullan91 requested a review from jackdclark March 13, 2019 14:34
jackdclark
jackdclark previously approved these changes Mar 13, 2019
Copy link
Contributor

@jackdclark jackdclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final tiny thing, but good to go 👍

@bmullan91 bmullan91 merged commit 1ea201a into master Mar 13, 2019
@bmullan91 bmullan91 deleted the guide_migrating_from_apollo branch March 13, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants