Skip to content

feat: HTTP GET Support #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 27, 2019
Merged

feat: HTTP GET Support #410

merged 6 commits into from
Nov 27, 2019

Conversation

bmullan91
Copy link
Contributor

What does this PR do?

Adds HTTP GET support for queries:

  • One time use
  • For all queries
  • Directly calling client.request()

Related issues

#211

Checklist

  • I have checked the contributing document
  • I have added or updated any relevant documentation
  • I have added or updated any relevant tests

@bmullan91 bmullan91 mentioned this pull request Nov 26, 2019
Closed
3 tasks
@bmullan91 bmullan91 requested a review from mcollina November 26, 2019 23:05
mcollina
mcollina approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We should make the original commit have a Co-Authored-By: ... to keep attribution of the original PR.

@bmullan91 bmullan91 merged commit 0703076 into master Nov 27, 2019
@bmullan91 bmullan91 deleted the get-support-fixes-211 branch November 27, 2019 09:32
@bmullan91 bmullan91 mentioned this pull request Nov 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmullan91 @mcollina