Skip to content

ScrollViewBase is missing setNativeProps #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cpunion opened this issue Nov 10, 2017 · 0 comments
Closed

ScrollViewBase is missing setNativeProps #709

cpunion opened this issue Nov 10, 2017 · 0 comments

Comments

@cpunion
Copy link
Contributor

cpunion commented Nov 10, 2017

Do you want to request a feature or report a bug?

BUG.

What is the current behavior?

Some libraries likes react-native-swipe-list-view using ListView.setNativeProps for performance, ListView.setNativeProps calls ScrollView.setNativeProps, and then calls ScrollViewBase.setNativeProps (See https://github.com/necolas/react-native-web/blob/master/src/components/ScrollView/index.js#L52), but ScrollViewBase missing setNativeProps.

Uncaught TypeError: this._scrollViewRef.setNativeProps is not a function
    at Object.setNativeProps (index.js:1)
    at ListView.setNativeProps (index.js:1)
    at SwipeListView.setScrollEnabled (SwipeListView.js:28)

If the current behavior is a bug, please provide the steps to reproduce and
if a minimal demo of the problem via Glitch or similar (template:
https://glitch.com/edit/#!/react-native-web-playground).

What is the expected behavior?
ScrollView.setNativeProps works fine.

Environment (include versions). Did this work in previous versions?

  • OS: macOS 10.13.1
  • Device: MBP
  • Browser: Google Chrome
  • React Native for Web (version): 0.1.13
  • React (version): 16.0.0

I guess didn't work in previous versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant