Skip to content

Remove cluster ITs that manipulate cluster state #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

injectives
Copy link
Contributor

The following tests have been removed and superseded by Testkit tests:

  • CausalClusteringIT.shouldNotServeWritesWhenMajorityOfCoresAreDead -> RoutingV4x4.test_should_fail_when_writing_without_writers_using_session_run
  • CausalClusteringIT.shouldServeReadsWhenMajorityOfCoresAreDead -> RoutingV4x4.test_should_serve_reads_and_fail_writes_when_no_writers_available
  • CausalClusteringIT.shouldHandleGracefulLeaderSwitch -> RoutingV4x4.test_should_write_successfully_after_leader_switch_using_tx_run

The following tests have been removed and superseded by Testkit tests:
- `CausalClusteringIT.shouldNotServeWritesWhenMajorityOfCoresAreDead` -> `RoutingV4x4.test_should_fail_when_writing_without_writers_using_session_run`
- `CausalClusteringIT.shouldServeReadsWhenMajorityOfCoresAreDead` -> `RoutingV4x4.test_should_serve_reads_and_fail_writes_when_no_writers_available`
- `CausalClusteringIT.shouldHandleGracefulLeaderSwitch` -> `RoutingV4x4.test_should_write_successfully_after_leader_switch_using_tx_run`
Copy link

@AndyHeap-NeoTech AndyHeap-NeoTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@injectives injectives merged commit ef1bce7 into neo4j:4.4 Nov 25, 2021
@injectives injectives deleted the feature/tests branch November 25, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants