docs: don't skip VIMRUNTIME in lua lsp if ~/.config/nvim/.luarc.json exists #3603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that |
…rc.json exists .luarc is created by lua-lsp itself (e.g. if you hit "disable diagnostics" in a code action), at which point the lsp will start showing errors that the vim global is undefined after the next restart.
justinmk
reviewed
Feb 6, 2025
| @@ -48,7 +48,7 @@ require'lspconfig'.lua_ls.setup { | |||
| on_init = function(client) | |||
| if client.workspace_folders then | |||
| local path = client.workspace_folders[1].name | |||
| if vim.loop.fs_stat(path..'/.luarc.json') or vim.loop.fs_stat(path..'/.luarc.jsonc') then | |||
| if path ~= vim.fn.stdpath('config') and (vim.loop.fs_stat(path..'/.luarc.json') or vim.loop.fs_stat(path..'/.luarc.jsonc')) then | |||
There was a problem hiding this comment.
the PR title says if ~/.config/nvim/.luarc.json exists but here you are comparing path ~= vim.fn.stdpath('config') ("NOT equal to ~/.config/nvim") ... ?
There was a problem hiding this comment.
the PR says "DON'T" skip the runtime if this directory exists. if this condition is taken, then the code does an early return, and the runtime is never loaded. so we want the condition to be false when the directory exists, hence ~= instead of ==.
justinmk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.luarc is created by lua-lsp itself (e.g. if you hit "disable diagnostics" in a code action), at which point the lsp will start showing errors that the
vimglobal is undefined after the next restart.