Fix device_role to role breaking change in netbox_device module #1062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the Ansible NetBox module to accommodate recent changes in the NetBox API where `device_role` has been renamed to `role`. Also made corresponding adjustments in the pynetbox library to ensure compatibility.
|
We can't just stop supporting 3.5 and 3.4, so the device_role and role will have to live side by side for a while. We should also note about deprecation on the device_role field. |
|
Hi @shaul75, Thanks for your PR and taking the initiative to submit a fix! As @rodvand stated, we still need to support previous versions so logic must be added to make this change dependent on the version of Netbox. I created #1066 with the fix for backwards compatibility if you want to check it out. If you'd like, I can submit a PR into your fork based off of your PR to ensure you get credit for the fix as well. This would obviously delay the fix dependent on our schedules, but figured I'd at least ask. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the Ansible NetBox module to accommodate recent breaking changes in the NetBox API where
device_rolehas been renamed torole. Also made corresponding adjustments in the pynetbox library.Related Issue
New Behavior
...
Contrast to Current Behavior
...
Discussion: Benefits and Drawbacks
...
Changes to the Documentation
...
Proposed Release Note Entry
...
Double Check
develbranch.