Skip to content

Display FHRP Group name on VM Interface page #18976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hzc12321 opened this issue Mar 21, 2025 · 0 comments · Fixed by #19246
Closed

Display FHRP Group name on VM Interface page #18976

hzc12321 opened this issue Mar 21, 2025 · 0 comments · Fixed by #19246
Assignees
Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone

Comments

@hzc12321
Copy link

hzc12321 commented Mar 21, 2025

NetBox version

v4.2.5

Feature type

Change to existing functionality

Proposed functionality

In Virtualization > Interfaces > (any interface), only the Group ID, Protocol, Virtual IP and Priority of the FHRP groups are displayed. Besides of these columns, the name column should also be displayed.

Use case

Neither the group ID, protocol or the combination of both forms a unique record. There could be cases where the FHRP group ID and protocol are exactly the same. Virtual IP, on the other hand, is not intuitive for users to identify which FHRP group it really is. Displaying the group names eliminates the need for users to trace down one-by-one by clicking into the FHRP group details.

For example, in IPAM > IP Addresses > (any IP assigned to a FHRP group as VIP), at the "Assignment" column, the name of the FHRP group is displayed alongside protocol and group ID. This is ideal and the interface page should also follow.

The default table on IPAM > FHRP groups has similar issue, where the group name is not displayed by default, but the table here can be configured to display group name, so it's not really causing big problem here, it would be great to add the name column into the list of default selected columns. Another way of solving this would be making the table of FHRP groups on the interface page configurable, but I don't think this will bring much additional benefit, while it is probably the more complex approach.

An ultimate approach is to make FHRP group name a mandatory field which only allows unique entries, and attach the hyperlink to the group name instead of group ID. The reason being is the same : Neither the group ID, protocol or the combination of both forms a unique record. Then, it is intuitive that the FHRP group name becomes the representation of the group and therefore must be displayed anywhere related.

Database changes

Only applicable if it is decided to continue with the ultimate approach of making FHRP group name a mandatory and unique field. Changes needed to the database is self-explanatory.

External dependencies

No response

@hzc12321 hzc12321 added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels Mar 21, 2025
@jnovinger jnovinger added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation and removed status: needs triage This issue is awaiting triage by a maintainer labels Mar 27, 2025
@jeremystretch jeremystretch added the complexity: low Requires minimal effort to implement label Mar 27, 2025
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Apr 18, 2025
@jeremystretch jeremystretch added this to the v4.2.8 milestone Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants