Closes #18976 Display FHRP Group name on VM Interface page #19246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatoalmeidaoliveira
requested review from
a team and
jeremystretch
and removed request for
a team
jeremystretch
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #18976 Display FHRP Group name on VM Interface page
The
FHRPGroupmodel defines a logic for its__str__representation, as seen in the code implementation. However, theINTERFACE_FHRPGROUPStemplate currently uses a different representation forFHRPGroup, instead of relying on its__str__method.Since the
__str__representation already encapsulates all the necessary data for this use case, it makes sense to standardize the logic by ensuringINTERFACE_FHRPGROUPSutilizes theFHRPGroupmodel’s__str__method when displaying the field.