Skip to content

allow filtering of interfaces in the gui by 802.1Q Mode #18978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ITJamie opened this issue Mar 21, 2025 · 2 comments · Fixed by #19183
Closed

allow filtering of interfaces in the gui by 802.1Q Mode #18978

ITJamie opened this issue Mar 21, 2025 · 2 comments · Fixed by #19183
Assignees
@pheus
Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone
v4.2.8

Comments

@ITJamie
Copy link
Contributor

ITJamie commented Mar 21, 2025

NetBox version

v4.2.5

Feature type

Change to existing functionality

Proposed functionality

add 802.1q mode as an option on the interfaces filter form.

Use case

currently in the interfaces filter gui theres no option to filter by 802.1q mode. its possible to filter it right now by adding ?mode=tagged-all to the interfaces ui.
filtering by poe mode is already an option so its a bit odd that 802.1q mode isnt available

Database changes

n/a

External dependencies

n/a
@ITJamie ITJamie added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels Mar 21, 2025
@jnovinger jnovinger added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation complexity: low Requires minimal effort to implement and removed status: needs triage This issue is awaiting triage by a maintainer labels Mar 27, 2025
@pheus
Copy link
Contributor

pheus commented Apr 13, 2025

Hi @jnovinger,
I'd like to contribute this. Would you mind assigning the issue to me?

I’ve already implemented the feature and chose to use a MultipleChoiceFilter for the mode field, which would be a breaking change. Would that be acceptable, or would you prefer I stick with a single mode filter? This could potentially be included in the upcoming v4.3 release.

I went with a MultipleChoiceFilter as it feels more consistent with how PoE mode filtering is handled, but I’m happy to adjust based on what works best for the project.

@jeremystretch
Copy link
Member

@pheus assigned to you, thanks!

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Apr 14, 2025
@pheus pheus mentioned this issue Apr 14, 2025
Merged
@jeremystretch jeremystretch added this to the v4.2.8 milestone Apr 15, 2025
@jeremystretch jeremystretch mentioned this issue Apr 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pheus pheus

Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
v4.2.8
Development

Successfully merging a pull request may close this issue.

Fixes #18978 - Allow filtering of Interfaces in the GUI by 802.1Q Mode pheus/netbox
4 participants
@jnovinger @ITJamie @jeremystretch @pheus