Fixes #18978 - Allow filtering of Interfaces in the GUI by 802.1Q Mode #19183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested changes
Apr 15, 2025
pheus
commented
Apr 15, 2025
Introduces a new FilterSet for VLAN mode in CommonInterfaceFilterSet. This allows filtering interfaces based on their VLAN mode using defined choices.
Add a field to InterfaceFilterSet to filter interfaces by 802.1Q VLAN mode.
Add a field to VMInterfaceFilterSet to filter interfaces by 802.1Q VLAN mode.
Updates the `mode` filter parameter to accept a list instead of a single value in `test_filtersets.py`. Ensures proper count assertion for accurate test behavior.
Introduces tests to validate filtering by `mode` for VMInterface. Ensures correct filtering for 802.1Q VLAN mode.
Splits the 'Attributes' FieldSet into two distinct FieldSets for better clarity: 'Attributes' and 'Addressing'. This improves form organization and makes it more intuitive for users.
pheus
force-pushed
the
18978-allow-filtering-of-interface-by-802-1q
branch
from
f788ac7 to
a8bb17f
Compare
|
I've removed the commits related to VLAN Translation Policy filtering and kept the split of the FieldSet as discussed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18978 - Allow filtering of Interfaces in the GUI by 802.1Q Mode
This PR enhances VLAN filtering and filter form usability for the DCIM and Virtualization modules by adding VLAN mode filtering, updating tests, and refactoring field organization.
Changes
VLAN Mode Filtering:
Refactoring:
Impact
These improvements allow users to efficiently filter interfaces by VLAN mode.
I opted for a
MultipleChoiceFilterto maintain consistency with how PoE mode filtering is handled, even though this introduces a breaking change.Thank you for reviewing this PR!