Skip to content

The load_yaml() convenience method on BaseScript should use SafeLoader #19189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jeremystretch opened this issue Apr 15, 2025 · 0 comments · Fixed by #19190
Closed

The load_yaml() convenience method on BaseScript should use SafeLoader #19189

jeremystretch opened this issue Apr 15, 2025 · 0 comments · Fixed by #19190
Assignees
@jeremystretch
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Milestone
v4.2.8

Comments

@jeremystretch
Copy link
Member

Deployment Type

Self-hosted

NetBox Version

v4.2.7

Python Version

3.10

Steps to Reproduce

N/A

Expected Behavior

The load_yaml() method on BaseScript should use the SafeLoader class for safety.

Observed Behavior

The default Loader class is used.
@jeremystretch jeremystretch added severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application labels Apr 15, 2025
@jeremystretch jeremystretch self-assigned this Apr 15, 2025
@jeremystretch jeremystretch added this to the v4.2.8 milestone Apr 15, 2025
jeremystretch added a commit that referenced this issue Apr 15, 2025
@jeremystretch
Fixes #19189: BaseScript.load_yaml() should use SafeLoader
e71aa4b
@jeremystretch jeremystretch mentioned this issue Apr 15, 2025
Merged
@jeremystretch jeremystretch mentioned this issue Apr 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeremystretch jeremystretch

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
v4.2.8
Development

Successfully merging a pull request may close this issue.

Fixes #19189: BaseScript.load_yaml() should use SafeLoader netbox-community/netbox
1 participant
@jeremystretch