Fixes RelatedObjectDoesNotExist #12368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthanson
approved these changes
May 1, 2023
There was a problem hiding this comment.
@jeremystretch Looking at this I think the fix is fine, but edge-case - If I'm reading the flow correctly the form doesn't have a form field referencing HardwareNotice object, and only sets it if validation passes - however super().clean() is called at start and I think this will cause a model-clean which will cause the NetBoxModel clean to be run which will error as these fields are blank.
I can't think of any negative effect from this change, but edge-case that I think most people wouldn't run into. I think the plugin code could also be re-factored to set object before calling the super.clean
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12367