-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Closes #12988: Introduce custom field choice sets #13195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line separated appears to have issues when used on Windows clients. Quick and dirty fix is to replace CRLF with LF only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also noticed when you add a custom field "Choice set" is only valid if you have selection type - we should add a PR to change the form to use HTMX so "Choice Set" is only displayed if you have a selection type.
Fixes: #12988
CustomFieldChoiceSet
modelchoice_set
ForeignKey toCustomField
and remove thechoices
array fieldArrayWidget
to improve UX while editing choices