Skip to content

Closes #14134: Display additional object attributes in global search results #14154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 9, 2023

Conversation

jeremystretch
Copy link
Member

@jeremystretch jeremystretch commented Oct 31, 2023

Closes: #14134

  • Add display_attrs attribute to SearchIndex
  • Add display_attrs property on CachedValue to render object attributes
  • Extend CachedValueSearchBackend to support prefetching related objects

@jeremystretch jeremystretch added this to the v3.7 milestone Nov 1, 2023
@jeremystretch jeremystretch marked this pull request as ready for review November 1, 2023 19:12
Copy link
Collaborator

@arthanson arthanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think display_attrs needs to be added to documentation https://docs.netbox.dev/en/stable/plugins/development/search/

@arthanson arthanson self-requested a review November 9, 2023 16:27
@jeremystretch jeremystretch merged commit 3d20276 into feature Nov 9, 2023
@jeremystretch jeremystretch deleted the 14134-search-display-attrs branch November 9, 2023 21:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants